Skip to content

feat: support setting up 1.21+ server links#101

Draft
TTtie wants to merge 8 commits intoPGMDev:devfrom
TTtie:feat/server-links
Draft

feat: support setting up 1.21+ server links#101
TTtie wants to merge 8 commits intoPGMDev:devfrom
TTtie:feat/server-links

Conversation

@TTtie
Copy link
Copy Markdown
Contributor

@TTtie TTtie commented Jan 4, 2026

Adds support for setting up server links in the pause menu on supported clients (1.21+). Works on both modern servers, and 1.8-based servers using ViaVersion.

Since this requires #94 to be merged first, this is marked as a draft to allow for comments, and testing.

Comment thread core/src/main/java/dev/pgm/community/serverlinks/ServerLinksConfig.java Outdated
@TTtie TTtie force-pushed the feat/server-links branch from efe6233 to 8d859e6 Compare January 6, 2026 00:36
@TTtie TTtie changed the base branch from platform to dev January 6, 2026 00:36
@TTtie TTtie force-pushed the feat/server-links branch from be7b445 to 8d859e6 Compare January 6, 2026 00:39
@TTtie TTtie force-pushed the feat/server-links branch 2 times, most recently from 18484de to bd3c33a Compare February 1, 2026 18:27
@TTtie TTtie force-pushed the feat/server-links branch 2 times, most recently from a8c1768 to af3f27f Compare February 13, 2026 03:29
@TTtie TTtie marked this pull request as ready for review February 13, 2026 03:31
@TTtie TTtie force-pushed the feat/server-links branch from af3f27f to cb3cd82 Compare April 15, 2026 20:30
@TTtie TTtie marked this pull request as draft April 24, 2026 21:33
TTtie and others added 6 commits April 24, 2026 23:40
Adds support for setting up server links in pause menu on supported clients (1.21+). Works on both modern, and 1.8-based servers using ViaVersion.

Signed-off-by: TTtie <me@tttie.cz>
Avoids blowing things up when ViaVersion isn't present.

Signed-off-by: TTtie <me@tttie.cz>
Local artifacts :(

Signed-off-by: TTtie <me@tttie.cz>
Co-authored-by: Pablo Herrera <pabloherrerapalacio@gmail.com>
Signed-off-by: TTtie <me@tttie.cz>
A more proper fix is TBD

Signed-off-by: TTtie <me@tttie.cz>
@TTtie TTtie force-pushed the feat/server-links branch from cb3cd82 to dfda6df Compare April 24, 2026 21:59
TTtie added 2 commits April 27, 2026 00:12
Refactors the implementation and implements a hook for the FINISH_CONFIGURATION packet in the ViaVersion path to be used as the signal to send server links instead of the PlayerJoinEvent. This should reduce the risk of a race condition resulting in a protocol error occurring, as the client should already expect play-state packets after this.

The modern path is untested for the time being due to migration to PacketEvents on the PGM dev branch.

Signed-off-by: TTtie <me@tttie.cz>
Signed-off-by: TTtie <me@tttie.cz>
@TTtie TTtie force-pushed the feat/server-links branch from 3438bec to ea9cae0 Compare April 27, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants