fix(raids): extend level selector to 1-10 (#259)#278
Conversation
The raid/egg add dialog hardcoded `levels = [1, 2, 3, 4, 5, 6]`, preventing users from configuring Elite Raids (level 7) or any custom server-defined levels through the UI even though PoracleNG accepts arbitrary integers and bot `!command` users were already creating higher-level alarms that displayed correctly. Extend to `[1..10]` — covers stock Pokémon GO (1-5 + Mega), Elite Raids (~7) and a buffer for custom schemes. Edit dialog and backend already handle arbitrary integers; no other changes needed. Reported by @prof-miles0 in #259.
|
Superseding this with a proper redesign. PoracleNG accepts arbitrary integer levels — capping at 10 just moves the problem rather than fixing it. Replacement PR introduces a chip-based selector (Standard / Special / Custom sections), named labels for Mega and Elite, and an inline 'add custom level' input that handles 9000 (any), 42, or whatever your server uses. New PR ID to follow. |
|
I might be wrong, Jabes knows more about this, but I think that raid levels go even higher than 10. Shadow raids and a few others. I have no PC this weekend… I can check next week EDIT: You can find all raid levels and tags/names in the gamemaster. Available here: https://github.com/WatWowMap/Masterfile-Generator/blob/8db1fd5c1a9401db59f4ce053be76f04e0e88812/master-latest-poracle-v2.json Search for raid_{level} |
2 participants
Summary
Fixes #259 (reported by @prof-miles0).
The raid/egg add dialog hardcoded
levels = [1, 2, 3, 4, 5, 6], so the UI couldn't reach Elite Raids (level 7) or any custom server-defined levels even though PoracleNG accepts arbitrary integers and bot!commandusers were already creating higher-level alarms that displayed correctly in the read-only edit dialog.Change
One-line bump to
[1..10]inraid-add-dialog.component.ts:76, with a comment explaining the range:The edit dialog already displayed arbitrary existing levels read-only, and the backend imposes no upper bound — no other changes needed. CHANGELOG entry under [Unreleased] → Fixed.
Test plan