Update build.zig to compile on the latest stable Zig 0.15.2#894
Open
bernardassan wants to merge 2 commits intoPCRE2Project:mainfrom
Open
Update build.zig to compile on the latest stable Zig 0.15.2#894bernardassan wants to merge 2 commits intoPCRE2Project:mainfrom
bernardassan wants to merge 2 commits intoPCRE2Project:mainfrom
Conversation
Add a named LazyPath to pcre2_h so library uses can add pcre2_h to their projects include paths Add some more config_h options Correctly set PCRE2_EXPORT Signed-off-by: Bernard Assan <mega.alpha100@gmail.com>
NWilson
reviewed
Mar 21, 2026
Member
|
Thank you for this contribution! I have raised some questions, but in principle, if it builds for you and on our CI, I am happy to accept it. |
Author
|
I will update this PR in the morning, done some changes already |
remove unused config options make visibility actually work (tested to be working with my project https://github.com/bernardassan/Glib/tree/glib_tests) even though I was resisting, expose "pcre2posix.h" as a named LazyPath for users who want to use this api instead Add sanitize_c option Signed-off-by: Bernard Assan <mega.alpha100@gmail.com>
Author
|
Updated PR with suggestions from the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a named LazyPath called
pcre2.h, which library users can import and add to their projects' include directory, like https://github.com/bernardassan/Glib/blob/49ef9727f43d41011baa1f3961076a29ebebb515/build/glib/root.zig#L93Add some more config_h options
Correctly set PCRE2_EXPORT