Configure sym files to solve Solaris SPARC symbol issue#884
Merged
Conversation
NWilson
force-pushed
the
user/niwilson/lib-version-sym-fix
branch
5 times, most recently
from
ae2e2b6 to
f8b29bb
Compare
NWilson
force-pushed
the
user/niwilson/lib-version-sym-fix
branch
from
f8b29bb to
c6b7255
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a fix recently to add the
_lib_versionsymbol to our version script, to fix the Solaris SPARC build (which I can't test - reported by user).This broke Solaris x64 and FreeBSD however. So, I'm now making the change to generate these files conditionally with a configure check. Hopefully this will close the issue fully.