Fix propagation of generator expressions from parent directory#883
Merged
Fix propagation of generator expressions from parent directory#883
Conversation
sergio-nsk
reviewed
Feb 22, 2026
CMakeLists.txt
Outdated
| list(APPEND CMAKE_REQUIRED_DEFINITIONS "-D${_def}") | ||
| if(_def STREQUAL "_GNU_SOURCE") | ||
| list(APPEND CMAKE_REQUIRED_DEFINITIONS "-D${_def}") | ||
| endif() |
There was a problem hiding this comment.
I would replace the foreach with list(FIND _pcre2_compile_definitions "_GNU_SOURCE" _idx).
72370d0 to
7cb7bc3
Compare
7cb7bc3 to
3dc2bd5
Compare
Member
Author
|
Thank you for reviewing. I have also added a CI test so we do not regress again on this particular behaviour. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CMake build would fail if invoked from a parent directory with a generator expression set on COMPILE_DEFINITIONS:
This is a regression.
My code was overly broad; I propagated much more than I intended.