chore: simplify SDL2 guard in examples/CMakeLists.txt#8
Merged
Conversation
The EXISTS check for third-party/CMakeLists.txt was always true (the file is tracked in git), so it added noise without guarding anything. Drop it and trim the skip message to match. Follow-up cleanup to the imgui FetchContent fix from 6fd1ea0 / #6. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
PABannier
force-pushed
the
chore/simplify-sdl2-guard
branch
from
1034099 to
1fd0251
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/third-party/CMakeLists.txt"half of the guard was dead — that file is tracked in git and therefore always present, so the condition was effectively justif(SDL2_FOUND).Follow-up cleanup to the imgui FetchContent fix landed in 6fd1ea0 (which resolved the practical symptom reported in #6).
Test plan
cmake ..succeeds on macOS with SDL2 installed and still buildssam3_image/sam3_videocmake ..on a machine without SDL2 printsSDL2 not found — skipping GUI examplesand still buildssam3_benchmark/sam3_quantize🤖 Generated with Claude Code