Skip to content

fix(import): harden WinSCP password and site import reliability#78

Closed
Orinks wants to merge 2 commits intodevfrom
fix/winscp-importer-reliability-clean
Closed

fix(import): harden WinSCP password and site import reliability#78
Orinks wants to merge 2 commits intodevfrom
fix/winscp-importer-reliability-clean

Conversation

@Orinks
Copy link
Owner

@Orinks Orinks commented Mar 4, 2026

Replacement for #77 with clean commit history to satisfy GitGuardian.

Includes:

  • WinSCP decrypt reliability fixes (upstream-aligned)
  • INI encoding/URL-decoding hardening
  • WinSCP-specific import UX messaging
  • sanitized fixture + runtime-generated encrypted test values

Supersedes #77.

@gitguardian
Copy link

gitguardian bot commented Mar 4, 2026

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
27836301 Triggered Generic Password f31d82b tests/fixtures/importers/winscp_real_export_sanitized.ini View secret
27836302 Triggered Generic Password f31d82b tests/fixtures/importers/winscp_real_export_sanitized.ini View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Orinks
Copy link
Owner Author

Orinks commented Mar 4, 2026

Closing in favor of original PR #77 (branch force-updated with clean history).

@Orinks Orinks closed this Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant