fix(a11y): set initial focus for Air Quality, UV Index, Discussion dialogs#420
Merged
fix(a11y): set initial focus for Air Quality, UV Index, Discussion dialogs#420
Conversation
…iscussion dialogs NVDA announces nothing useful when these dialogs open because no control receives focus. Add SetFocus() calls so screen readers land on the primary content control (hourly forecast TextCtrl when data is present, Close button otherwise; discussion_display for the Discussion dialog). Closes #409 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Cover the SetFocus calls added in 05b3e6c for screen reader accessibility (issue #409). Five tests verify that focus lands on _hourly_display when data exists and on the Close button otherwise (AQ & UV), plus discussion_display for DiscussionDialog. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Orinks
force-pushed
the
fix/accessiweather-issue-409
branch
from
eef010a to
b523bc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetFocus()on the primary content control when opened, so NVDA (and other screen readers) announce meaningful content immediatelyTextCtrl; when no data is available, focus lands on the Close buttondiscussion_displaytext controlCloses #409
Test plan
🤖 Generated with Claude Code