Support Windows build systems#3
Closed
tobiasweibel wants to merge 2 commits into
Closed
Conversation
Basically to support Windows build systems.
tobiasweibel
commented
Mar 2, 2018
| "eol": "^0.9.1", | ||
| "handlebars": "4.0.6", | ||
| "react-docgen": "2.14.0", | ||
| "react-docgen-markdown-renderer": "1.0.1" |
Author
There was a problem hiding this comment.
An update is pending. Basically PR OriR/react-docgen-markdown-renderer#6 needs to be merged first.
Owner
|
As I mentioned here, I'm working on a new version and hopefully it'll handle this :) |
Owner
|
Your change assumes the output of the renderer is always a string. If it's still an issue, I feel it's the responsibility of each renderer to make sure it's compatible with the OS. I'm closing this PR, but feel free to comment if you feel there's more to it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.