refactor(config): Streamline environment variable retrieval#18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to environment variable management and updates some test data. The main focus is on simplifying how environment variables are accessed in the configuration code, and ensuring that the necessary environment variables are passed to the deployment script. Additionally, some test files have been updated with new paths.
Environment variable management:
get_envfunction insrc/config.pyto prioritize override values and direct environment variables, removing the previous fallback to GitHub Action input variables. This makes configuration handling more straightforward and predictable.action.ymlfile to explicitly pass a comprehensive set of environment variables to the deployment script, ensuring all necessary context and secrets are available during execution.Test data updates:
.env.database,.env.redis,.env.s3) to reflect new test directories, likely due to changes in test execution or environment setup. [1] [2] [3]