Merge the CMake build by Martin Hauke#2
Merged
russel merged 3 commits intoOpendigitalradio:masterfrom Jan 28, 2017
Merged
Conversation
Member
|
No strong opinion on the topic, but a preference for having one thing that works well, not several build systems and nobody never knows which one is the good one. |
Author
|
@mpbraendli I think then that removing the Make build and focusing solely on the CMake build is the right thing to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a pull request on the original linuxstb dabtools (linuxstb#6) Martin Hauke added a CMake build for DABtools. This pull request is my merge of his changes to this fork of the repository.
Do we want a Meson build as well as the CMake build?
Do we remove the pure Make build or leave it?