Fix Final cancel on LimitOrderHook#128
Open
luiz-lvj wants to merge 4 commits into
Open
Conversation
✅ Deploy Preview for uniswap-hooks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for uniswap-hooks-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #127
currency*Totalinto aBalanceDeltabefore zeroing and pass it throughCancelCallbackData._handleCancelCallback'sremovingAllLiquiditybranch, burn the snapshot's worth of hook-held ERC-6909 claims and fold them intoprincipalDelta, so the canceller receivesprincipal + prior feesin one take tocancelData.to.test_cancelOrder_removingAllLiquidity(its assertion encoded the bug) and addtest_cancelOrder_finalCancel_*tests for the basic strand, balance reconciliation, multi-cancel compounding, single canceller, place-callback fee path, separate recipient, and cross-order isolation.This PR should be merged after #126