fix: remove hardcoded test-artifacts, and rename compact pkg#5
Merged
Conversation
0xisk
changed the title
Closed
andrew-fleming
changed the title
Contributor
It's no longer needed now that |
Contributor
andrew-fleming
left a comment
andrew-fleming
left a comment
There was a problem hiding this comment.
Looking good, @0xisk! Left a few comments and questions :)
Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com> Signed-off-by: 0xisk <0xisk@proton.me>
Contributor
andrew-fleming
left a comment
andrew-fleming
left a comment
There was a problem hiding this comment.
Changes look great, @0xisk! I left two small questions
Contributor
There was a problem hiding this comment.
Since we're duplicating the set up with checks and tests, any reason not to make this one yml file?
Merged
emnul
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Changes:
compacttoclitool better until we figure out a better name.test-artifactsand compile thesample-contractsonly before testing the simulatorextendsinturbo.jsonnot sure why it was needed @emnul?