Skip to content

Update contract sizes benchmark#1686

Open
github-actions[bot] wants to merge 1 commit intomainfrom
update/contract-sizes-25313897357
Open

Update contract sizes benchmark#1686
github-actions[bot] wants to merge 1 commit intomainfrom
update/contract-sizes-25313897357

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 4, 2026

This PR updates the contract size benchmarks after a recent merge to main.

Summary by CodeRabbit

  • Chores
    • Updated contract size metrics for compiled test contracts to reflect current build measurements.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: de29ce31-1210-4d57-b01d-d9cc66a0df31

📥 Commits

Reviewing files that changed from the base of the PR and between 393f712 and b3efb1d.

📒 Files selected for processing (1)
  • benches/contract_sizes.json

Walkthrough

This PR updates benchmark metrics in benches/contract_sizes.json for OpenZeppelin Starknet test contracts. It adds a new size entry for ERC20ReturnFalseMock and revises bytecode and class sizes for multiple contracts, primarily showing reductions in compiled contract footprints.

Changes

Contract Size Metrics Update

Layer / File(s) Summary
Benchmark Metrics
benches/contract_sizes.json
Adds openzeppelin_test_common_ERC20ReturnFalseMock entry and updates size metrics (felts and bytes) for ERC20WrapperMock, all ERC4626* variants (AssetsFees, ExternalVault, Limits, Mock, MockWithHooks, Offset, SharesFees), and LinearVestingMock with revised (lower) compiled contract sizes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • ericnordelo
  • bidzyyys
  • immrsd

Poem

🐰 Size metrics shrink and dance,
ERC4626 leads the prance,
New MockFalse hops in to stay,
Leaner contracts light the way! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly reflects the main change: updating benchmark metrics for contract sizes in the benches/contract_sizes.json file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update/contract-sizes-25313897357

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant