Skip to content

openvidu-java-client : Remove redundant getSessionId() call #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lastname-dev wants to merge 2 commits into
base: master
Choose a base branch
from
+0 −8
Open

openvidu-java-client : Remove redundant getSessionId() call #820

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39f9ba0
openvidu-java-client : Remove redundant getSessionId() call in create…
lastname-dev Oct 16, 2023
f4d5677
openvidu-java-client : Remove redundant getSessionId()
lastname-dev Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions openvidu-java-client/src/main/java/io/openvidu/java/client/Session.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,6 @@ public String generateToken() throws OpenViduJavaClientException, OpenViduHttpEx
*/
@Deprecated
public String generateToken(TokenOptions tokenOptions) throws OpenViduJavaClientException, OpenViduHttpException {
if (!this.hasSessionId()) {
this.getSessionId();
}

final HttpClientResponseHandler<String> responseHandler = new HttpClientResponseHandler<String>() {
@Override
public String handleResponse(final ClassicHttpResponse response) throws IOException, HttpException {
Expand Down Expand Up @@ -182,10 +178,6 @@ public Connection createConnection() throws OpenViduJavaClientException, OpenVid
*/
public Connection createConnection(ConnectionProperties connectionProperties)
throws OpenViduJavaClientException, OpenViduHttpException {
if (!this.hasSessionId()) {
this.getSessionId();
}

final HttpClientResponseHandler<Connection> responseHandler = new HttpClientResponseHandler<Connection>() {
@Override
public Connection handleResponse(final ClassicHttpResponse response) throws IOException, HttpException {
Expand Down