Add Graph::trace_assertion_failure and fix duplicate error_message symbol#220
Merged
Add Graph::trace_assertion_failure and fix duplicate error_message symbol#220
Conversation
- Declare and stub Graph::trace_assertion_failure(bool, const char*, ...) - Call trace_assertion_failure(true, ...) in precondition_failure - Call trace_assertion_failure(false, ...) in non_fatal_precondition_failure - Remove dead OAG_TARGET_RELEASE guard that was never defined
Use internal linkage for error_message to avoid linker collision when both OpenAttributeGraph and OpenRenderBox are linked together.
🤖 Augment PR SummarySummary: Introduces a new Changes: Removes an unused release-guard and makes 🤖 Was this summary useful? React with 👍 or 👎 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
=======================================
Coverage 32.08% 32.08%
=======================================
Files 70 70
Lines 2596 2596
=======================================
Hits 833 833
Misses 1763 1763
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Graph::trace_assertion_failure(bool, const char*, ...)declaration and stub implementationtrace_assertion_failurecalls intoprecondition_failure(withtrue) andnon_fatal_precondition_failure(withfalse), matching the original AG binary#if OAG_TARGET_RELEASE >= OAG_RELEASE_2023guard that was never definederror_messagestatic to avoid duplicate symbol error when linked with OpenRenderBoxTest plan
swift buildpasses