Skip to content

Fix : disable omniauth profile edition#955

Merged
BarbaraOliveira13 merged 26 commits intodevelopfrom
fix/disable-omniauth-profile-edition
Apr 3, 2026
Merged

Fix : disable omniauth profile edition#955
BarbaraOliveira13 merged 26 commits intodevelopfrom
fix/disable-omniauth-profile-edition

Conversation

@moustachu
Copy link
Copy Markdown
Member

@moustachu moustachu commented Mar 11, 2026

🎩 Description

This PR "fixes" (FranceConnect team point of view) the behavior of the OMNIAUTH_FORCE_PROFILE_SYNC flag.

There is a new configuration variable OMNIAUTH_FORCE_PROFILE_SYNC_FIELDS for selecting the fields concerned by the profile synchronization.
This only works with the name and email (which is the original default behavior).

When email is not the list of synchronized field, the user has to follow the standard workflow of validating the new email address.

This also fixes a SSO caveats where you need to type in your current password when changing your email :

  • both SSO and standard email / password sign in are enabled
  • the user only uses SSO sign in and has never set his password
  • the user change hi email address
  • the user is asked for his current password which doesn't exists
  • the account form doesn't accept empty password
  • the user needs to log out and use the reset password before changing is email

The fixes disable the password check when there isn't any password set AND the user is currently signed in with SSO.

Testing

You need a platform with with SSO configuration and the related flag enabled.
But this has been tested by the FranceConnect qualification team on 2 platform.

🛠️ If your PR introduces or updates an Override

  • Add the label "override:pending" in your PR
  • Add the corresponding label based on the review deadline category (when this override must be checked):
    • WHEN BACKPORT 0.29 ·
    • BEFORE MIGRATION 0.31 ·
    • WAITING FOR PR UPSTREAM ·
    • OTHER
  • Add the link to the related Decidim issue or PR (if exist).

Quentinchampenois and others added 25 commits June 24, 2025 11:23
release: v3.2.0
* feat: Release 3.3.0

* fix: Remove assembly update for Decidim Geo (#852)
Add tracking issue templates
This PR bumps budgets_booth to its latest commit, to fix problem with the last voting popup.
OpenSourcePolitics/intern-tasks#317
* fix: udpate default partial to display custom publik translation

* style: update with rubocop
* fix: Unescape HTML entities in component index checkbox tree (deface)

* fix: system test
* fix: update creat_proposal extends to integrate private body from awesome

* test: update creat_proposal test with private body
* fix: add validation on editor image form to avoid special characters

* fix: add javascript to handle errors on editor form

* test: add tests
* Revert "Update issue templates"

This reverts commit 5a37ad4.

* add condition

* add condition in a method decidim_ai_disabled?

* update default flag of decidim_ai to false

* update default value and delete decidim_ai reference in text mail

* debug CI, search clue

* fix CI by disabled Redis for Decidim_Ai in test

* initialize decidim_ai_enabled to false before secrets

* fix CI

* fix CI

* test CI

* add config analyzer in first place

* clean

* refacto

---------

Co-authored-by: moustachu <moustachu@opensourcepolitics.eu>
* feat: update budgets_booth to latest commit

* fix: add regenerator-runtime dependence to fix error
@moustachu moustachu added Override:pending Override en attente de review / nettoyage Before migration 0.31 Date / situation prévue pour re-valider la pertinence de l'override ou besoin de supprimer labels Mar 11, 2026
Copy link
Copy Markdown
Collaborator

@BarbaraOliveira13 BarbaraOliveira13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Let me know If you need a third product review after deployment ...

@BarbaraOliveira13 BarbaraOliveira13 merged commit ae36aef into develop Apr 3, 2026
23 of 26 checks passed
@BarbaraOliveira13 BarbaraOliveira13 deleted the fix/disable-omniauth-profile-edition branch April 3, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Before migration 0.31 Date / situation prévue pour re-valider la pertinence de l'override ou besoin de supprimer Override:pending Override en attente de review / nettoyage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants