fix(spp_registrant_gis): add GIS view for res.partner and promote to Beta#86
fix(spp_registrant_gis): add GIS view for res.partner and promote to Beta#86
Conversation
…Beta Add missing GIS view, data layer, and raster layer for res.partner to fix "No GIS view defined" error when opening Individual/Group forms with the geo_point widget. Also add module icon and promote to Beta.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 19.0 #86 +/- ##
=======================================
Coverage 69.15% 69.16%
=======================================
Files 628 632 +4
Lines 35632 35639 +7
=======================================
+ Hits 24643 24649 +6
- Misses 10989 10990 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the geographical information system capabilities for registrant records by introducing a dedicated GIS view for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a GIS view for res.partner to resolve an error and promotes the module to Beta status. A security review found no vulnerabilities. I've also provided a suggestion to improve the name of the new raster layer for better maintainability.
|
|
||
| <record id="gis_raster_layer_registrant_osm" model="spp.gis.raster.layer"> | ||
| <field name="raster_type">osm</field> | ||
| <field name="name">Default</field> |
There was a problem hiding this comment.
The name "Default" for the raster layer is a bit generic. Using a more descriptive name like "OpenStreetMap" would improve clarity and maintainability, making it immediately clear what this layer represents without needing to check the raster_type.
| <field name="name">Default</field> | |
| <field name="name">OpenStreetMap</field> |
1 participant
Why is this change needed?
geo_pointwidget callsget_edit_info_for_gis_column()which requires a GIS view to existHow was the change implemented?
type="gis") forres.partnerwith id, name, display_name, coordinates fieldscoordinatesGeoPointField to the GIS viewspp_registrydevelopment_statusfrom Alpha to BetaNew unit tests
No new tests added. Existing 5 tests in
spp_registrant_giscover field creation and coordinate assignment.Unit tests executed by the author
Existing test suite verified.
How to test manually
spp_registrant_gismoduleRelated links