fix(ci): remove stale paths from biome check step in lint.yml#3096
Open
fix(ci): remove stale paths from biome check step in lint.yml#3096
Conversation
biome.json restricts linting to packages/**/*.ts via its includes filter, so passing .claude/scripts/ and .claude/skills/setup-spa/ to the biome check command was a no-op — biome reported 0 files processed for those paths and silently skipped them. Remove the stale paths so the CI step accurately reflects what biome actually checks.
la14-1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
biome.jsonrestricts linting via"includes": ["packages/**/*.ts"]— it only processes files underpackages/lint.ymlbiome step was passing.claude/scripts/and.claude/skills/setup-spa/as extra paths, but biome silently ignored both (0 files processed from those paths)Fix: Remove the two stale paths so the CI command matches what biome actually lints.
Root cause
The
.claude/scripts/and.claude/skills/setup-spa/TypeScript files usetry/catch(banned inpackages/by theno-try-catch.gritplugin) — they were intentionally excluded from biome's scope. The lint.yml step was not updated to reflect this.Test plan
bunx @biomejs/biome check packages/cli/src/ packages/shared/src/→ 177 files, 0 errorsbun testinpackages/cli→ 1951 pass, 0 fail-- qa/code-quality