fix(security): expand $HOME before path validation in downloadFile (#3080)#3081
Open
fix(security): expand $HOME before path validation in downloadFile (#3080)#3081
Conversation
Fixes #3080 Prevents path traversal via other $VAR expansions by normalizing $HOME to ~ before the strict path regex check, removing the need to allow $ in the charset. Applied to all 5 cloud providers: - digitalocean: downloadFile - aws: downloadFile - sprite: downloadFileSprite - gcp: uploadFile + downloadFile - hetzner: downloadFile Also bumps CLI version to 0.27.7. Agent: security-auditor Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
downloadFile(and GCPuploadFile) allowed any$VARin remote paths — this is a path traversal vector via$OLDPWD,$PWD, etc. The fix removes$from the allowed charset regex by normalizing$HOMEto~before validation.Fixes #3080
Changes
downloadFile— expand$HOME→~before regex validation, remove$from charsetdownloadFile— same fixdownloadFileSprite— same fix, update variable reference fromexpandedPathtonormalizedRemoteuploadFileanddownloadFile— same fix (GCP had$in upload too)downloadFile— same fixTest plan
bunx @biomejs/biome check src/passes with 0 errorsbun test— all 1951 tests pass$HOME/.configstill work (normalized to~/.config)$OLDPWD/../etc/passwdare now rejected-- refactor/security-auditor