fix: auto-log Tinker inference costs from ART managed openai_client#620
Open
vivekkalyan wants to merge 1 commit intomainfrom
Open
fix: auto-log Tinker inference costs from ART managed openai_client#620vivekkalyan wants to merge 1 commit intomainfrom
vivekkalyan wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
costs/{train,eval}/tinker_prefillandcosts/{train,eval}/tinker_samplefor calls made through ART's managedmodel.openai_client()LocalBackend.register()when model pricing existsWhy
Internal repo's
PipelineTrainerpath was using ART-managed inference but was not emitting Tinker rollout costs unless the codebase manually calledmodel.cost_calculator(...). This moves that responsibility into ART so repos do not need rollout-side plumbing.Notes
openai_client()calls auto-log costs when an ART metrics context is activeOther option
Validation
.venv/bin/python -m pytest tests/unit/test_model_openai_client_costs.py tests/unit/test_track_api_cost.py -q