fix: guard against uninitialized G1 Arm Action Client#2405
Open
0xbyt4 wants to merge 1 commit intoOpenMind:mainfrom
Open
fix: guard against uninitialized G1 Arm Action Client#24050xbyt4 wants to merge 1 commit intoOpenMind:mainfrom
0xbyt4 wants to merge 1 commit intoOpenMind:mainfrom
Conversation
Initialize self.client to None before the try block so it is always defined. Add a None check in connect() to skip actions gracefully when hardware initialization failed.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
G1ArmActionClient()constructor fails (e.g. robot not connected, CycloneDDS unavailable),self.clientis never assigned because the assignment is inside thetryblock. Theexceptblock logs the error and continues, but any subsequentconnect()call crashes withAttributeError.The original code intended graceful degradation (catch + log), but didn't handle the connect-after-failed-init case. This fix completes that intent by initializing
self.client = Nonebefore thetryblock and adding a guard inconnect().