fix: hotfix release — series limit, past-event RSVP, iCal tracking#578
Merged
Conversation
Three hotfixes for user-reported issues: 1. Series occurrence query limit raised from 20 to 500. Weekly series running 5+ months (e.g. Kona Freethinkers, 22 events) had newest events truncated, showing as "missed" on the series page. 2. Prevent RSVP to past events. Users could RSVP after an event ended, causing confusion when email notifications went out for stale events. 3. Calendar invite attachments changed from METHOD:REQUEST to METHOD:PUBLISH. REQUEST triggered accept/decline in email clients, creating a shadow RSVP channel that bypassed OpenMeet (reported by CRMC). PUBLISH makes invites informational "add to calendar" only. Fixes: om-gedq, om-0214, om-5f1m
43857a2 to
f149c5a
Compare
… change - events-attendees.e2e-spec.ts: move default test event dates from 2024-12-31 to 2099-12-31 so RSVP tests pass the new past-event guard in attendance.service.ts - calendar-invite.e2e-spec.ts: update METHOD:REQUEST assertions to METHOD:PUBLISH to match the ical.service.ts switch to PUBLISH (informational attachment, prevents shadow RSVP channel via email clients — CRMC report)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hotfix release branch with three user-reported fixes, cut from current prod baseline (
4d06997) ahead of #574 and #576.Deploy plan
Do not merge yet — this branch should be deployed independently first.
Test plan