Skip to content

fix: hotfix release — series limit, past-event RSVP, iCal tracking#578

Merged
tompscanlan merged 2 commits into
mainfrom
release/hotfix-2026-04-16
Apr 16, 2026
Merged

fix: hotfix release — series limit, past-event RSVP, iCal tracking#578
tompscanlan merged 2 commits into
mainfrom
release/hotfix-2026-04-16

Conversation

@tompscanlan
Copy link
Copy Markdown
Contributor

Summary

Hotfix release branch with three user-reported fixes, cut from current prod baseline (4d06997) ahead of #574 and #576.

  • Series query limit (om-gedq): Raised from 20 to 500. Weekly series running 5+ months had newest events truncated, showing as "missed" on the series page. Reported by Steve Munkelt (Kona Freethinkers).
  • Past-event RSVP guard (om-0214): Block RSVP after event ends. 6 users RSVP'd to a past event because the series page couldn't find the materialized occurrence.
  • iCal METHOD:PUBLISH (om-5f1m): Calendar invite attachments changed from REQUEST to PUBLISH, removing accept/decline buttons that created a shadow RSVP channel bypassing OpenMeet. Reported by Kurt (CRMC).

Deploy plan

  1. Build image from this branch
  2. Deploy to dev, verify fixes
  3. Deploy to prod
  4. Merge this PR into main after feat(contrail): integrate Contrail appview for AT Protocol event queries #574/feat: unified AttendanceService for all RSVP operations #576 are ready to ship

Do not merge yet — this branch should be deployed independently first.

Test plan

  • Verify Steve's "Weekly Discussion Topics" series shows all 22 events as materialized
  • Verify RSVP to a past event returns 400 error
  • Verify calendar invite email uses METHOD:PUBLISH (no accept/decline buttons)
  • Verify RSVP to future events still works normally

Three hotfixes for user-reported issues:

1. Series occurrence query limit raised from 20 to 500. Weekly series
   running 5+ months (e.g. Kona Freethinkers, 22 events) had newest
   events truncated, showing as "missed" on the series page.

2. Prevent RSVP to past events. Users could RSVP after an event ended,
   causing confusion when email notifications went out for stale events.

3. Calendar invite attachments changed from METHOD:REQUEST to
   METHOD:PUBLISH. REQUEST triggered accept/decline in email clients,
   creating a shadow RSVP channel that bypassed OpenMeet (reported by
   CRMC). PUBLISH makes invites informational "add to calendar" only.

Fixes: om-gedq, om-0214, om-5f1m
@tompscanlan tompscanlan force-pushed the release/hotfix-2026-04-16 branch from 43857a2 to f149c5a Compare April 16, 2026 18:56
… change

- events-attendees.e2e-spec.ts: move default test event dates from 2024-12-31
  to 2099-12-31 so RSVP tests pass the new past-event guard in
  attendance.service.ts
- calendar-invite.e2e-spec.ts: update METHOD:REQUEST assertions to
  METHOD:PUBLISH to match the ical.service.ts switch to PUBLISH (informational
  attachment, prevents shadow RSVP channel via email clients — CRMC report)
@tompscanlan tompscanlan merged commit 8ac6efe into main Apr 16, 2026
4 checks passed
@tompscanlan tompscanlan deleted the release/hotfix-2026-04-16 branch April 16, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant