Translate mission mob names on quest addition#4203
Merged
Henrybk merged 1 commit intoOpenKore:masterfrom Apr 1, 2026
Merged
Conversation
Register the quest_mission_added event and add a handler to translate mission mob names when missions are added at runtime. Introduces _translate_single_token_inplace (to handle single-token strings) and questMissionAdded which validates quest/mission data, runs token and single-token translation on mission->{mob_name}, skips entries flagged as missing, and updates the mission name in-place.
Henrybk
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register the quest_mission_added event and add a handler to translate mission mob names when missions are added at runtime. Introduces _translate_single_token_inplace (to handle single-token strings) and questMissionAdded which validates quest/mission data, runs token and single-token translation on mission->{mob_name}, skips entries flagged as missing, and updates the mission name in-place.
Before:
After:
