Consolidate duplicate feedback solicitation in PR reviews#251
Merged
Conversation
Add a line to the mandatory review footer asking users to react with 👍 or 👎 so we can track how review quality changes are perceived. Co-authored-by: openhands <openhands@all-hands.dev>
The reactions feedback line is deterministic output that should appear on every review. Moving it from the reusable code-review skill into the pr-review plugin's prompt.py keeps it: - Scoped to the pr-review plugin rather than every /codereview consumer - Colocated with other deterministic output formatting (evidence, delegation) - Less likely to be paraphrased or dropped by the agent Co-authored-by: openhands <openhands@all-hands.dev>
Remove the separate _FEEDBACK_FOOTER from prompt.py that was causing a redundant, visually disjointed thumbs-up/down line after the detailed 'Improve this review?' blockquote. The reaction ask is now part of the blockquote in the code-review skill, so reviews render one cohesive footer instead of two stacked solicitations. Co-authored-by: openhands <openhands@all-hands.dev>
all-hands-bot
approved these changes
May 20, 2026
Contributor
all-hands-bot
left a comment
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Clean refactoring that consolidates duplicate feedback solicitations into a single cohesive block.
[RISK ASSESSMENT]
- [Overall PR]
⚠️ Risk Assessment: 🟢 LOW
Purely formatting change that simplifies code by removing duplication. No functional behavior modified.
VERDICT:
✅ Worth merging: Eliminates UX friction and reduces code complexity
KEY INSIGHT:
The best way to fix duplication is to consolidate, not coordinate.
Was this automated review useful? React with 👍 or 👎 to this review to help us measure review quality.
Workflow run: https://github.com/OpenHands/extensions/actions/runs/26180518436
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR reviews posted by the pr-review plugin had two separate, visually disjointed feedback solicitations stacked at the bottom:
code-reviewskill inSKILL.md)_FEEDBACK_FOOTERinprompt.py)This created an awkward
---→ blockquote →---→ plain text sandwich at the end of every review.Example: OpenHands/software-agent-sdk#3324 (review)
Fix
_FEEDBACK_FOOTERconstant and its append informat_prompt()fromplugins/pr-review/scripts/prompt.pyWas this review helpful? React with 👍 or 👎 to give feedback.) into the existing "Improve this review?" blockquote inskills/code-review/SKILL.mdNow reviews render one cohesive feedback block instead of two.
This PR was created by an AI agent (OpenHands) on behalf of the user.