Fix SQLite source-tree migration discovery

[neubig]

Summary

• Extract SQLite migration path discovery into a helper.
• Preserve packaged migration discovery while checking the source checkout repo-root migrations/ path via package_dir.parent.parent / "migrations".
• Retain the previous package_dir.parent / "migrations" path as a legacy fallback.
• Add tests covering packaged, source checkout, legacy fallback, and missing-path behavior.

Fixes #128.

Tests

• uv run pytest tests/test_app_migrations.py -v
• uv run ruff check openhands/automation/app.py tests/test_app_migrations.py
• uv run ruff format --check openhands/automation/app.py tests/test_app_migrations.py
• uv run pre-commit run --files openhands/automation/app.py tests/test_app_migrations.py --show-diff-on-failure
• Attempted uv run pytest tests/ -v --ignore=tests/integration, but the full suite could not complete because this environment does not have a Docker daemon available for testcontainers.

This PR was created by an AI agent (OpenHands) on behalf of the user.

@neubig can click here to continue refining the PR

[github-actions]

🚀 Deploy Preview PR Created/Updated

A deploy preview has been created/updated for this PR.

Deploy PR: https://github.com/OpenHands/deploy/pull/4348
Automation SHA: 010b40af90dc09d7d8b0c65413d3f8b6716c7230
Last updated: May 19, 2026, 11:26:15 PM ET

Once the deploy PR's CI passes, the automation service will be deployed to the feature environment.

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
__init__.py	1	0	100%
app.py	153	76	50%	59, 62, 65, 71, 73, 76, 79–82, 85, 90–92, 94, 96, 98–99, 101–102, 105–111, 114–115, 118, 125–126, 129–130, 134, 142–143, 146, 153–154, 156, 159–160, 163, 168–176, 178–180, 286–288, 293–294, 296–297, 299, 302–304, 306–307, 309–310, 315–316, 320, 323, 325
auth.py	146	7	95%	82, 110, 119, 156, 376, 384–385
config.py	158	0	100%
constants.py	17	0	100%
db.py	67	29	56%	60, 74–75, 78–80, 82, 89, 92–93, 96, 104, 111, 144, 147–148, 152–153, 161, 169, 174, 201, 204–210
dispatcher.py	186	45	75%	70, 82, 84–85, 137, 199–202, 237, 240, 255–256, 262–264, 281–282, 288–292, 295–297, 307, 373–374, 399–406, 426, 441–442, 456–457, 466–467, 469
event_router.py	59	19	67%	83, 88, 119–121, 137–138, 156, 158, 160–161, 163, 173, 179–181, 184, 186, 188
exceptions.py	4	0	100%
execution.py	220	133	39%	39–41, 76–79, 87–91, 93, 101–103, 108–112, 114, 128–131, 133, 135, 137–140, 142–147, 149, 151–158, 160–161, 163, 199–201, 207–209, 220–223, 229–231, 271–275, 284, 292, 296, 298–299, 304–305, 310, 388–389, 473–475, 477–483, 486–487, 489, 491–493, 496, 499, 502–505, 507, 510–511, 514–516, 520–521, 525–528, 530, 538–539, 543–545, 547–553, 557, 559, 568–570, 572–574
filter_eval.py	50	2	96%	161–162
logger.py	55	17	69%	37, 50–51, 53–59, 74, 77, 101, 103–106
models.py	81	0	100%
preset_router.py	190	56	70%	143–145, 255–256, 261–268, 273, 276, 278–279, 291–294, 296–300, 305, 314, 386–388, 501–502, 507–514, 519, 522, 524–525, 537–540, 542–546, 551, 561
router.py	117	65	44%	80–81, 101, 103, 106, 108, 122, 135, 137–138, 140–141, 143–144, 147–149, 160–162, 180–183, 202, 205, 208, 215, 217, 251–253, 256–258, 262–263, 268, 272–275, 277, 285, 287–288, 293–294, 297, 299, 301–303, 306–309, 314, 316–317, 326, 347–349, 353
scheduler.py	60	9	85%	134–135, 172–173, 188–189, 199–200, 202
schemas.py	270	17	93%	32, 166, 172–174, 233–235, 237, 342–343, 346, 351, 356, 500, 508, 515
trigger_matcher.py	28	3	89%	72–74
uploads.py	107	59	44%	142–145, 153–155, 161–162, 165, 174–175, 178–179, 187–188, 190–193, 196–199, 201, 203–205, 207–210, 212–213, 215, 230, 236–237, 240, 243, 246, 249, 251, 264–265, 279, 282–284, 286–287, 289, 295–296, 309, 317–319, 323
watchdog.py	98	45	54%	55–57, 69–70, 162–163, 204–205, 207, 209, 218, 220–222, 224, 231–233, 235–237, 239–240, 242, 257, 259, 264–267, 269–274, 276–282, 284
webhook_router.py	80	48	40%	57, 82–83, 107–108, 110, 113–114, 116, 126, 128–132, 137, 139, 151, 154, 157, 164–165, 167, 180, 182–183, 188, 204, 206–207, 213–215, 217–218, 220, 235, 237–238, 243–244, 261, 263–264, 270–271, 273, 275
backends
__init__.py	13	0	100%
base.py	29	0	100%
cloud.py	130	62	52%	43–45, 50–52, 103, 116–118, 131–135, 142–143, 145, 147, 159–160, 229–230, 232–233, 235–238, 240–245, 247–255, 257–258, 260, 267–269, 272–273, 275, 282–284, 289–293, 295
local.py	43	0	100%
event_schemas
__init__.py	29	1	96%	53
custom.py	33	5	84%	52–53, 64–66
detection.py	32	0	100%
github.py	125	4	96%	306, 311, 456, 483
presets
__init__.py	0	0	100%
storage
__init__.py	6	0	100%
factory.py	15	1	93%	36
file_store.py	22	5	77%	21, 30, 35, 40, 64
google_cloud.py	72	11	84%	49, 97–102, 136–137, 190, 192
local.py	68	0	100%
s3.py	112	15	86%	56, 100, 102–103, 107, 109, 190, 213–215, 269–270, 275, 337–338
utils
__init__.py	5	0	100%
agent_server.py	53	0	100%
api_key.py	32	24	25%	40–41, 46–48, 50, 55, 60, 62–65, 67–68, 70–71, 73, 79, 81–82, 89, 91–92, 98
cron.py	45	6	86%	39, 45, 74, 80, 123, 140
log_context.py	10	0	100%
model_profiles.py	11	0	100%
run.py	84	14	83%	74–76, 183–184, 200–202, 207–209, 256, 262–263
sandbox.py	71	61	14%	49–50, 55–58, 60–62, 64–70, 80–81, 86–92, 115–116, 118–122, 124–128, 159–160, 162, 164–167, 172–173, 176, 180–181, 187–189, 194–196, 201–202, 210–212, 214
tarball_validation.py	48	0	100%
time.py	3	0	100%
webhook.py	57	9	84%	47, 52, 120, 130–132, 138, 201–202
TOTAL	3295	848	74%

[all-hands-bot]

🟢 Good taste - Clean refactoring that extracts migration path discovery into a testable helper while maintaining backward compatibility through a prioritized fallback chain.

[RISK ASSESSMENT]

• [Overall PR] ⚠️ Risk Assessment: 🟢 LOW
  Backward-compatible refactoring with comprehensive test coverage. All previous migration paths are preserved as fallbacks, ensuring no breaking changes for packaged installs, source checkouts, or legacy layouts.

VERDICT:
✅ Worth merging: Solid engineering that fixes issue #128 with well-tested code.

KEY INSIGHT:
The three-candidate fallback approach elegantly handles multiple deployment contexts (packaged wheel, source checkout, legacy) without special-case logic, making the code both maintainable and robust.

---

Was this automated review useful? React with 👍 or 👎 to this review to help us measure review quality.
Workflow run: https://github.com/OpenHands/automation/actions/runs/26139299198