fix: keep panel resize drag working over files iframes#729
Conversation
|
@nehaprasad-dev is attempting to deploy a commit to the openhands Team on Vercel. A member of the Team first needs to authorize it. |
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Clean, standard solution to the iframe event capture problem.
This implements the classic drag shield pattern: a full-viewport overlay that keeps mouse events on the parent document when dragging over iframes. Using useLayoutEffect ensures the shield is mounted before paint, preventing any missed events.
The implementation is focused and correct:
- Proper accessibility (
aria-hidden) - Clean setup/teardown
- Good test coverage
[RISK ASSESSMENT]
- [Overall PR]
⚠️ Risk Assessment: 🟢 LOW
UI-only change affecting panel resize interaction. Focused, single-responsibility implementation with good test coverage. No breaking changes or architectural concerns.
VERDICT:
✅ Worth merging - Solves a real UX issue with the standard, proven approach.
Was this automated review useful? React with 👍 or 👎 to this review to help us measure review quality.
Workflow run: https://github.com/OpenHands/agent-canvas/actions/runs/26265909609
|
Confirmed this is working! |
summary
Issue Number
fix : #724
How to Test
Video/Screenshots
N/A
Type
[x] Bug fix
Notes
N/A