fix(chat): enable git PR/push/pull on local without provider_tokens_set#722
Open
nehaprasad-dev wants to merge 1 commit into
Open
fix(chat): enable git PR/push/pull on local without provider_tokens_set#722nehaprasad-dev wants to merge 1 commit into
nehaprasad-dev wants to merge 1 commit into
Conversation
|
@nehaprasad-dev is attempting to deploy a commit to the openhands Team on Vercel. A member of the Team first needs to authorize it. |
all-hands-bot
approved these changes
May 21, 2026
Contributor
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Clean refactoring that centralizes providerTokensReady logic. Fixes local backend git buttons correctly.
[IMPROVEMENT OPPORTUNITIES]
- Consider adding test coverage for the new local backend behavior (buttons enabled when repo detected)
[RISK ASSESSMENT]
- [Overall PR]
⚠️ Risk Assessment: 🟢 LOW
Simple UI logic change that fixes button enable/disable behavior on local backends. No impact on agent behavior, prompts, or evaluation performance. Cloud backend behavior unchanged.
VERDICT:
✅ Worth merging: Logic is sound, good refactoring, no breaking changes
KEY INSIGHT:
Properly decouples local vs cloud authentication models - local backends use git credentials, not provider API tokens.
Was this automated review useful? React with 👍 or 👎 to this review to help us measure review quality.
Workflow run: https://github.com/OpenHands/agent-canvas/actions/runs/26248114933
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Summary
Issue Number
fix #718
How to Test
Video/Screenshots
N/A
Type
[x] Bug fix
Notes
Does not save inferred repo on the conversation.