Fix 1-4 interpolation for core-dummy interactions#1856
Conversation
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
The 4 tests introduced to show that 1-4 interactions between the core-dummy atoms has failed as expected https://github.com/OpenFreeEnergy/openfe/actions/runs/22312817357/job/64549319567?pr=1856#step:11:6546. Now turning on the setting by default which should fix the tests. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1856 +/- ##
==========================================
- Coverage 94.72% 90.55% -4.18%
==========================================
Files 216 216
Lines 19546 20480 +934
==========================================
+ Hits 18515 18545 +30
- Misses 1031 1935 +904
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hannahbaumann
left a comment
There was a problem hiding this comment.
Thanks @jthorton , lgtm! Thank you for adding all those thorough tests, I tried to go through all of them, but since it's so many I may have missed something, so it will be great to have another set of eyes on this!
IAlibay
left a comment
There was a problem hiding this comment.
This looks good to me, thanks! Could you just address @hannahbaumann's comments please?
Sorry it took so long for me to wrap my head around the exceptions stuff - it makes sense now.
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
|
No API break detected ✅ |
This fixes the treatment of 1-4 interactions between core and dummy atoms and extensive tests to the hybrid topology factory to ensure they are handled correctly.
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofix.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin