Re-add the xPPTRF routines (rename xPOTRF routines from #3123)#3229
Merged
andrew-platt merged 3 commits intoOpenFAST:rc-4.2.1from Mar 3, 2026
Merged
Re-add the xPPTRF routines (rename xPOTRF routines from #3123)#3229andrew-platt merged 3 commits intoOpenFAST:rc-4.2.1from
andrew-platt merged 3 commits intoOpenFAST:rc-4.2.1from
Conversation
commit 75d4c40 changed the xPPTRF routines to call the xPOTRF lapack routines, but we want to keep both.
Collaborator
Author
|
For easier code comparison of #3123 with this PR, see andrew-platt#30 |
deslaughter
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready to merge. Merge immediately after #3123
Feature or improvement description
PR #3123 changed the
NWTC_LAPACK.f90*PPTRFroutines into*POTRFroutines without changing the names or some of the comments appropriately.Related issue, if one exists
#3123, comment #3123 (comment)
Impacted areas of the software
TurbSim calculation speed only
Additional supporting information
see #3123
Generative AI usage
none
Test results, if applicable
No changes