regtest: check if destination dirs exist before copyTree call#3228
Merged
andrew-platt merged 4 commits intoOpenFAST:rc-4.2.1from Mar 3, 2026
Merged
regtest: check if destination dirs exist before copyTree call#3228andrew-platt merged 4 commits intoOpenFAST:rc-4.2.1from
andrew-platt merged 4 commits intoOpenFAST:rc-4.2.1from
Conversation
deslaughter
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
Occasionally an AeroDyn BAR regression test could fail with strange file IO related issues. After some brainstorming with @deslaughter we concluded that the
copyTreecommand for theBAR_Baselinedirectory (called inside theexecuteAerodynRegressionCase.py) was rewriting the airfoil files while other BAR tests might be trying to read them. To avoid this, thecopyTreeonly occurs if the directory doesn't exist already (there could still be system timing causing rewrites anyhow, but should be less frequent -- this is addressed in 5.0.0).Also we decided that our preference is to not copy over the directory every time we run the regression test locally - this works better with our development workflow where we want to keep manual input file changes between test runs.
Related issue, if one exists
Showed up during testing with https://github.com/OpenFAST/openfast/actions/runs/22595786003/attempts/1
Impacted areas of the software
Testing only
Additional supporting information
none
Generative AI usage
none
Test results, if applicable
none