patina_dxe_core: Add missing safety comments and enable clippy lint#1402
Merged
makubacki merged 1 commit intoOpenDevicePartnership:mainfrom Mar 16, 2026
Conversation
Contributor
QEMU Validation FailedQEMU validation did not complete successfully or did not shutdown as expected. Workflow run: https://github.com/OpenDevicePartnership/patina/actions/runs/23073788308 Job Results
This comment was automatically generated by the Patina QEMU PR Validation Post workflow. |
github-actions
Bot
added
impact:non-functional
Adds safety comments to the remaining unsafe blocks in patina_dxe_core and enables the clippy lint for missing safety docs. This allows future contributions to have the lint enforced. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
finish_patina_dxe_core_unsafe_enabling
branch
from
8114d88 to
97f3628
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
SBSA failure is unrelated to this PR:
Filed an issue to track whatever is needed for that in OpenDevicePartnership/patina-dxe-core-qemu#142. |
os-d
approved these changes
Mar 16, 2026
vineelko
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #583
Closes #1396
Adds safety comments to the remaining unsafe blocks in patina_dxe_core and enables the clippy lint for missing safety docs.
This allows future contributions to have the lint enforced.
How This Was Tested
cargo make allwith theundocumented_safety_blocksclippy lint enabled inpatina_dxe_coreIntegration Instructions
Note: Skipping code coverage check on this PR.