Update embassy-sync and embassy-executor#753
Update embassy-sync and embassy-executor#753bramsdell-ms wants to merge 2 commits intoOpenDevicePartnership:mainfrom
Conversation
Minimal version bumps only - no API or code changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update tps6699x dependency to use bramsdell-ms fork on embassy-sync-0.8 branch, which bumps embassy-sync from 0.7.2 to 0.8.0 to match the rest of the workspace. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Cargo Vet Audit Failed
If the unvetted dependencies are not neededPlease modify Cargo.toml file to avoid including the dependencies. If the unvetted dependencies are neededPost a new comment with the questionnaire below to the PR to help the auditors vet the dependencies. Copy and paste the questionnaire as a new comment and provide your answers:1. What crates (with version) need to be audited? 2. How many of the crates are version updates vs new dependencies? 3. To confirm none of the already included crates serve your needs, please provide a brief description of the purpose of the new crates. 4. Any extra notes to the auditors to help with their audits. |
| toml = { version = "0.8", default-features = false } | ||
| syn = "2.0" | ||
| tps6699x = { git = "https://github.com/OpenDevicePartnership/tps6699x" } | ||
| tps6699x = { git = "https://github.com/bramsdell-ms/tps6699x", branch = "embassy-sync-0.8" } |
There was a problem hiding this comment.
This can be undone when the OpenDevicePartnership/tps6699x#89 lands
|
As mentioned on OpenDevicePartnership/tps6699x#89, these versions have not been published to crates.io yet so we can't merge this until that is the case. |
|
Which repos are acceptable to refer to by git vs. need to be in crates.io? One option might be to change to a git reference. |
I believe we are trying to stick to crates.io releases only for Embassy. Recently we migrated away from git deps to crates.io for Embassy: #479 @jerrysxie does this match your understanding as well? |
@kurtjd @bramsdell-ms We switched to crate.io version to be more stable for our clients due to some subtle dependency between the embassy crates. There is no set in stone rule regarding crate.io or git dependency. We just have to be consistent throughout the entire ODP stack to not cause embassy dependency conflict to cause subtle breakages. For this change, it will be a problem for us since embassy-imxrt is not updated, so if this merged, client downstream depending on embedded-services and embassy-imxrt might have issue as there will be 2 different versions of embassy-sync in the dependency tree. |
Updating versions for embassy-sync and embassy-executor. Dependent on OpenDevicePartnership/tps6699x#89