Refine markdown path detection in CodeView#71
Merged
BunsDev merged 2 commits intoMay 20, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors how CodeView decides whether the active view should be treated as “Markdown”, centralizing path-precedence logic so both the Markdown preview toggle and Markdown-specific layout behavior follow the same rules.
Changes:
- Introduces shared helpers to pick a preferred path (local path → tab path → source path) and detect Markdown from it.
- Reuses the shared Markdown detection for both the Markdown mode segmented control and the render-time padding behavior.
- Adds focused unit tests covering the intended precedence order for Markdown detection.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
cargo fmt --allcargo test -p warp-app markdown_path_detection --lib(3 passed; 0 failed; 3992 filtered out)git diff --check