Open
Conversation
…event frame dropping during web
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses frame skipping during streaming on macOS (OPEN-16) by adjusting jitter buffer targets for VideoToolbox's higher latency and adding platform-specific Electron settings.
Changes in
opennow-stable/src/renderer/src/gfn/webrtcClient.tsisMacOS()detection helper usingnavigator.userAgent/navigator.platformVIDEO_BASE_JITTER_TARGET_MAC_MS = 20andVIDEO_PRESSURE_JITTER_TARGET_MAC_MS = 38(vs 12ms/30ms on other platforms)receiverLatencyTargetsinitialization to use macOS-aware valuessetDecoderPressureModeandresetDecoderRecoveryStateto select macOS-specific targets whenplatformIsMacis trueChanges in
opennow-stable/src/main/index.tsbackgroundThrottling: falsetowebPreferencesto fully suppress renderer throttling beyond CLI switchesdarwinplatform) by handlingenter-html-full-screenandleave-html-full-screenevents to prevent compositor hiccups during transitions