Skip to content

Enhance deploy revision fallback to varMap REVISION#1063

Merged
HaiHui886 merged 1 commit into
mainfrom
sync_mr_2489_a66b70f
May 8, 2026
Merged

Enhance deploy revision fallback to varMap REVISION#1063
HaiHui886 merged 1 commit into
mainfrom
sync_mr_2489_a66b70f

Conversation

@csg-pr-bot
Copy link
Copy Markdown
Collaborator

Summary:

  • Enhanced the REVISION assignment logic in makeDeployEnv to prioritize the value from varMap["REVISION"], allowing for more flexible revision settings and easier debugging.
  • The fallback to the short commit ID now only occurs if the REVISION variable is not configured or is empty, maintaining compatibility with existing behavior.

@csg-pr-bot
Copy link
Copy Markdown
Collaborator Author

Depends on #1062

Copy link
Copy Markdown
Collaborator

@HaiHui886 HaiHui886 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HaiHui886 HaiHui886 merged commit a00346f into main May 8, 2026
7 checks passed
@HaiHui886 HaiHui886 deleted the sync_mr_2489_a66b70f branch May 8, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants