Skip to content

remove op, add underscore#3389

Open
EmilyRagan wants to merge 1 commit into
mainfrom
suite-group-method-discovery
Open

remove op, add underscore#3389
EmilyRagan wants to merge 1 commit into
mainfrom
suite-group-method-discovery

Conversation

@EmilyRagan
Copy link
Copy Markdown
Contributor

Closes #3386

@EmilyRagan EmilyRagan requested a review from ryanmelt May 20, 2026 17:10
@EmilyRagan EmilyRagan self-assigned this May 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.04%. Comparing base (c0482f0) to head (91b4fcb).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3389      +/-   ##
==========================================
+ Coverage   78.85%   79.04%   +0.18%     
==========================================
  Files         687      687              
  Lines       57285    57111     -174     
  Branches      728      728              
==========================================
- Hits        45174    45142      -32     
+ Misses      12033    11891     -142     
  Partials       78       78              
Flag Coverage Δ
python 80.03% <ø> (ø)
ruby-api 82.49% <ø> (+0.15%) ⬆️
ruby-backend 82.65% <100.00%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update documentation in script-runner.md

@EmilyRagan EmilyRagan force-pushed the suite-group-method-discovery branch from f2db969 to 91b4fcb Compare May 20, 2026 20:58
@EmilyRagan EmilyRagan requested a review from jmthomas May 20, 2026 20:58
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure anyone is using the op_xxx version but at least this is not a breaking change now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suite Group method discovery regex over-matches due to unanchored op_ alternative

2 participants