This repository was archived by the owner on Feb 13, 2020. It is now read-only.
Using empty folder can lead to broken URLs. #13
Open
bobvanderclay wants to merge 1 commit into
Open
Conversation
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an empty asset-merger.folder is specified (we put the rendered script and style directories into the root directory), Kohana_Assets::web_path returns a path with a leading slash.
This path is passed to Html::script and Html::style, which combines it with the path in Url::base (which returns a trailing slash), which results in doubles slashes in the URL. In some cases this has caused an issue.
I've used ltrim to remote the leading slash.