Skip to content

Broaden MP cache-invalidate to all messageprotection-* codes #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dav12072018 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

Broaden MP cache-invalidate to all messageprotection-* codes #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/imessage/aps_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,8 +250,12 @@ impl IMClient {
target: Some(target),
..
} = &payload {
if error_string == "ec-com.apple.messageprotection-802" {
// refreshing identity cache can fix this
if error_string.starts_with("ec-com.apple.messageprotection-") {
// refreshing identity cache can fix this; previously this only
// matched "-802" but the same recovery path also resolves "-6"
// (signature/decrypt verification failed) and other recoverable
// message-protection codes that indicate a stale per-device
// session key. See discussion in openbubbles-app#206.
let mut cache_lock = self.identity.cache.lock().await;
cache_lock.invalidate(&target, &sender);
}
Expand Down