Firstname, lastname#2721
Merged
simonredfern merged 8 commits intoOpenBankProject:developfrom Mar 5, 2026
Merged
Conversation
Moved to v5.1.0 (JSONFactory5.1.0.scala):
- Added UserWithNamesJsonV510 case class (same 13 fields: user_id, email, provider_id, provider, username, first_name, last_name, entitlements, views,
agreements, is_deleted, last_marketing_agreement_signed_date, is_locked)
- Added createUserWithNamesJSON factory method with AuthUser lookup
Updated v5.1.0 endpoint (APIMethods510.scala):
- Adds authUser = AuthUser.find(...) lookup
- Returns JSONFactory510.createUserWithNamesJSON(...) with first_name/last_name
- ResourceDoc response example changed from userJsonV400 → userWithNamesJsonV510
Updated v5.1.0 tests (UserTest.scala):
- 200-success scenario now extracts UserWithNamesJsonV510 and asserts first_name == "" / last_name == ""
- New scenario creates an AuthUser with firstName("Alice").lastName("Smith") and asserts both fields
Cleaned up v6.0.0:
- Removed getUserByProviderAndUsername ResourceDoc + endpoint from APIMethods600.scala
- Removed UserWithNamesJsonV600 case class from JSONFactory6.0.0.scala
- Removed createUserWithNamesJSON factory method from JSONFactory6.0.0.scala
- Deleted GetUserByProviderAndUsernameTest.scala
- Renamed userWithNamesJsonV600 → userWithNamesJsonV510 in SwaggerDefinitionsJSON.scala
Since v6.0.0 inherits all v5.1.0 endpoints, /obp/v6.0.0/users/provider/.../username/... automatically uses the improved v5.1.0 implementation — no
separate v6.0.0 endpoint needed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.