Skip to content

TST: avoid unneeded venv activation in tox.yml#374

Closed
neutrinoceros wants to merge 1 commit intoOpenAstronomy:mainfrom
neutrinoceros:tst/avoid-venv-activation
Closed

TST: avoid unneeded venv activation in tox.yml#374
neutrinoceros wants to merge 1 commit intoOpenAstronomy:mainfrom
neutrinoceros:tst/avoid-venv-activation

Conversation

@neutrinoceros
Copy link
Contributor

follow up to #353

I think this can be simplified, but let's see how CI actually react.

@Cadair
Copy link
Member

Cadair commented Mar 9, 2026

Does this actually prevent a venv being made / used?

https://docs.astral.sh/uv/reference/cli/#uv-tool-install says:

Packages are installed into an isolated virtual environment in the uv tools directory.

@neutrinoceros
Copy link
Contributor Author

neutrinoceros commented Mar 9, 2026

it doesn't, but that's also not my goal. I just want to prevent the env to be activated explicitly, since working with uv allows us to not manage (de)activation manually (hence why activate-environment is false by default).
Anyway I missed that toxdeps would mess this up. It could be parsed so that each dep is prepended with a -w (--with) flag, but then the end result wouldn't be simpler than what we started with, so overall it doesn't seem worth it.

@neutrinoceros neutrinoceros deleted the tst/avoid-venv-activation branch March 9, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants