SEC: address security issues detected with zizmor#363
Closed
neutrinoceros wants to merge 6 commits intoOpenAstronomy:mainfrom
Closed
SEC: address security issues detected with zizmor#363neutrinoceros wants to merge 6 commits intoOpenAstronomy:mainfrom
neutrinoceros wants to merge 6 commits intoOpenAstronomy:mainfrom
Conversation
Contributor
Author
|
to be specific, the main remaining audit is |
Contributor
Author
|
Not everything works out the box so I think I'm going to split this up to ease iteration and review |
Contributor
Author
|
re-issued into smaller PRs. Progress will be tracked in #364 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since these workflows are widely used and even run automated package uploads (e.g.
astropy-iers-data), it seems worth hardening their security as much as possible.I intend to enable
zizmor's pre-commit hook in a follow up PR. This first one contains a couple of semi-automated fixes, with each commit focused on a single audit.There are a couple remaining issues that I'll try to address next, but don't have auto-fixers available.