Conversation
Bumps [com.fasterxml.jackson.core:jackson-core](https://github.com/FasterXML/jackson-core) from 2.21.0 to 2.21.1. - [Commits](FasterXML/jackson-core@jackson-core-2.21.0...jackson-core-2.21.1) --- updated-dependencies: - dependency-name: com.fasterxml.jackson.core:jackson-core dependency-version: 2.21.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [com.fasterxml.jackson.core:jackson-databind](https://github.com/FasterXML/jackson) from 2.21.0 to 2.21.1. - [Commits](https://github.com/FasterXML/jackson/commits) --- updated-dependencies: - dependency-name: com.fasterxml.jackson.core:jackson-databind dependency-version: 2.21.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Remove unnecessary arrow function wrapper for mdtable helper in OpenWrap.template. This keeps the helper consistent with other helpers and reduces code noise.
Update ojob-all.yaml and ojob.md with detailed logToFile options. Adds defaults, templates, housekeeping, compression, backup, and in‑memory entry limits. Clarifies usage and removes legacy placeholders.
…l.jackson.core-jackson-databind-2.21.1 chore(deps): bump com.fasterxml.jackson.core:jackson-databind from 2.21.0 to 2.21.1
…l.jackson.core-jackson-core-2.21.1 chore(deps): bump com.fasterxml.jackson.core:jackson-core from 2.21.0 to 2.21.1
…d stream handling
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates OpenAF’s logging configuration documentation, exposes an existing markdown-table renderer as a template helper, refactors the ioStreamRead NIO path for simpler/encoding-safe reads, and bumps Jackson dependencies.
Changes:
- Expanded
logToFiledocumentation/examples to cover allow.ch.utils.setLogToFileoptions. - Added
$mdtableHandlebars helper wiring to render arrays as markdown tables. - Reworked
ioStreamRead(..., useNIO=true, ...)to useBufferedReader/InputStreamReaderand updated Jackson versions.
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
pom.xml |
Updates Jackson core/databind versions. |
js/owrap.template.js |
Wires $mdtable helper to ow.template.md.table. |
js/openaf.js |
Refactors ioStreamRead NIO branch to character-based buffered reading. |
docs/ojob.md |
Documents full logToFile option set with inline explanations. |
docs/ojob-all.yaml |
Updates the full config example for logToFile options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Co-authored-by: nmaguiar <11761746+nmaguiar@users.noreply.github.com>
Fix resource leak in `ioStreamRead` useNIO branch
- Renamed and replaced jackson-dataformat-toml JAR to version 2.21.1 - Updated pom.xml to add dependency on jackson-dataformat-toml 2.21.1 This updates the TOML dataformat dependency to the latest version for improved compatibility and bug fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and fixes across logging configuration, template helpers, stream reading performance, and dependency updates. The most significant changes are improvements to the logging configuration options for file logging, the addition of a markdown table helper to templates, a refactor of the NIO stream reading logic for better reliability, and an update to Jackson dependencies.
Logging configuration improvements:
logToFileconfiguration in bothdocs/ojob-all.yamlanddocs/ojob.mdto include new options such asfilenameTemplate,fileDateFormat,lineTemplate,lineDateFormat, housekeeping regex, backup folder, compression control, and in-memory log entry limits. These additions provide more granular control over log file naming, formatting, retention, and housekeeping. [1] [2]Template helper enhancements:
$mdtablehelper toowrap.template.js, allowing templates to render array objects as markdown tables. This makes it easier to generate markdown-formatted tables directly from data structures. [1] [2]Stream reading improvements:
ioStreamReadinopenaf.jsto use a buffered character reader instead of NIO channels and byte buffers. This simplifies the code and improves compatibility with different encodings and input streams.Dependency updates:
jackson-coreandjackson-databinddependencies inpom.xmlfrom version2.21.0to2.21.1to incorporate the latest bug fixes and improvements.