Skip to content

fix: remove query-token auth from transcription stream#38

Open
sammargolis wants to merge 1 commit intofix/auth-bootstrap-deadlockfrom
fix/sse-auth-without-query-token
Open

fix: remove query-token auth from transcription stream#38
sammargolis wants to merge 1 commit intofix/auth-bootstrap-deadlockfrom
fix/sse-auth-without-query-token

Conversation

@sammargolis
Copy link
Collaborator

Summary

  • removes URL query-token auth usage for hosted SSE transcription stream
  • authenticates stream and uploads via HttpOnly cookie and bearer-header fallback
  • updates client upload/stream plumbing to use credentials: include

Security impact

  • eliminates token leakage risk via URL/history/referrer/logs
  • keeps protected stream endpoint authorization intact

PHI handling impact

  • no new PHI storage introduced
  • reduces risk of auth token exposure in PHI-adjacent flows

Tests executed

  • pnpm build:test
  • pnpm exec tsc --project apps/web/tsconfig.json --noEmit

Rollback plan

  • revert this PR to restore previous SSE auth transport behavior

@sammargolis sammargolis force-pushed the fix/auth-bootstrap-deadlock branch from 45f215d to 7e737c7 Compare March 2, 2026 17:16
@sammargolis sammargolis force-pushed the fix/sse-auth-without-query-token branch from c516f2f to dc131e4 Compare March 2, 2026 17:16
@sammargolis sammargolis force-pushed the fix/auth-bootstrap-deadlock branch from 7e737c7 to af25b38 Compare March 2, 2026 17:19
@sammargolis sammargolis force-pushed the fix/sse-auth-without-query-token branch from dc131e4 to eb0a077 Compare March 2, 2026 17:19
@sammargolis sammargolis force-pushed the fix/auth-bootstrap-deadlock branch from af25b38 to 61643ca Compare March 2, 2026 17:23
@sammargolis sammargolis force-pushed the fix/sse-auth-without-query-token branch from eb0a077 to 7a66a19 Compare March 2, 2026 17:23
@sammargolis sammargolis force-pushed the fix/sse-auth-without-query-token branch from 7a66a19 to a1561e8 Compare March 3, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant