Skip to content

fix: ensure optional deps are installed in CI#929

Merged
soumeh01 merged 6 commits intomainfrom
install-deps
Apr 14, 2026
Merged

fix: ensure optional deps are installed in CI#929
soumeh01 merged 6 commits intomainfrom
install-deps

Conversation

@soumeh01
Copy link
Copy Markdown
Collaborator

@soumeh01 soumeh01 commented Mar 25, 2026

Changes

Add --prefer-offline --include=optional to all npm ci calls.

  • --prefer-offline: use cached packages where available, reducing network usage on CI runners.
  • --include=optional: ensure platform-specific esbuild binaries (e.g. @esbuild/linux-x64, @esbuild/darwin-arm64) are installed.
  • --no-fund: Disables messages about funding/supporting packages

These are required by tsx, which is used to run TypeScript scripts such as copyright:check, download-tools, and check:links.

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@soumeh01 soumeh01 force-pushed the install-deps branch 2 times, most recently from ebdc615 to 6b4ca61 Compare March 25, 2026 16:12
@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 25, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@soumeh01 soumeh01 changed the title Install dependencies with --prefer-offline --ignore-scripts option Install dependencies with --prefer-offline --include=optional option Mar 25, 2026
@soumeh01 soumeh01 changed the title Install dependencies with --prefer-offline --include=optional option fix: ensure optional deps are installed in CI Mar 25, 2026
@jreineckearm
Copy link
Copy Markdown
Collaborator

@soumeh01 , what's the status of this? Also, some merge conflicts came up.

@soumeh01 soumeh01 marked this pull request as ready for review April 13, 2026 08:46
Copy link
Copy Markdown
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But TBF: I unfortunately don't see much of a CI performance improvement. Probably because we don't use GH caches IIRC?

@soumeh01
Copy link
Copy Markdown
Collaborator Author

soumeh01 commented Apr 14, 2026

LGTM.

But TBF: I unfortunately don't see much of a CI performance improvement. Probably because we don't use GH caches IIRC?

Yes True, It looks like resource contention on the runner might also be affecting performance. At times, it runs significantly faster than what we are seeing now.

@soumeh01 soumeh01 merged commit c341802 into main Apr 14, 2026
21 checks passed
@soumeh01 soumeh01 deleted the install-deps branch April 14, 2026 10:45
@soumeh01 soumeh01 mentioned this pull request Apr 14, 2026
5 tasks
@soumeh01 soumeh01 restored the install-deps branch April 14, 2026 13:24
@soumeh01 soumeh01 deleted the install-deps branch April 14, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants