Skip to content

Sort&Filter: created new TreeView display#926

Open
thorstendb-ARM wants to merge 12 commits intomainfrom
filterEntriesSmart
Open

Sort&Filter: created new TreeView display#926
thorstendb-ARM wants to merge 12 commits intomainfrom
filterEntriesSmart

Conversation

@thorstendb-ARM
Copy link
Copy Markdown
Collaborator

@thorstendb-ARM thorstendb-ARM commented Mar 25, 2026

Implements

#925

Changes

  • Created new TreeView display
  • remaining code feeding VS Code treeview remains intact

Note

This PR serves as an implementation & test before deciding on the direction. Sorting and filtering of SCVD items will require changes on both the Component Viewer/Core Peripherals side and in the SCVD format.

Screenshot

image

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 31, 2026

Qlty


Coverage Impact

⬇️ Merging this pull request will decrease total coverage on main by 0.10%.

Modified Files with Diff Coverage (3)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
src/views/component-viewer/component-viewer-base.ts50.0%91, 94, 118-153
Coverage rating: A Coverage rating: A
src/views/component-viewer/component-viewer-tree-view.ts72.7%305-307
New Coverage rating: A
src/views/component-viewer/component-viewer-webview-provider.ts100.0%
Total88.4%
🤖 Increase coverage with AI coding...
In the `filterEntriesSmart` branch, add test coverage for this new code:

- `src/views/component-viewer/component-viewer-base.ts` -- Lines 91, 94, and 118-153
- `src/views/component-viewer/component-viewer-tree-view.ts` -- Line 305-307

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@thorstendb-ARM thorstendb-ARM marked this pull request as ready for review March 31, 2026 13:17
Copy link
Copy Markdown
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where this is going, but needs more polishing: code structure/maintainability of the HTML parts, styling, some missing buttons, column naming, location of the lock button, etc.

Please continue with this after the upcoming release. There I will go with the TreeView based variant. I think it will be easy enough for users to switch to the new design without major disrupt when it comes in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants