Skip to content

Ensure pack reference for solution local pack#2423

Open
edriouk wants to merge 2 commits intomainfrom
pack_ref
Open

Ensure pack reference for solution local pack#2423
edriouk wants to merge 2 commits intomainfrom
pack_ref

Conversation

@edriouk
Copy link
Copy Markdown
Collaborator

@edriouk edriouk commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses missing/incorrect pack reference reporting for solution local packs in the ProjMgr RPC layer (linked to issue #154), ensuring that packs resolved from local paths can be associated back to their originating pack requirements.

Changes:

  • Update pack-reference collection to avoid offering “upgrade” versions for project/solution-local packs (packs with an explicit path).
  • Update GetPacksInfo reference matching to associate references by resolved pack ID or by equivalent local pack path.
  • Add an RPC test covering the solution local pack scenario for GetPacksInfo.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tools/projmgr/src/ProjMgrRpcServer.cpp Improves how pack references are collected and matched (ID- or path-based) when generating GetPacksInfo.
tools/projmgr/test/src/ProjMgrRpcTests.cpp Adds a new test for GetPacksInfo in a solution local pack scenario.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Test Results

    3 files     21 suites   17m 49s ⏱️
  456 tests   456 ✅ 0 💤 0 ❌
1 368 runs  1 368 ✅ 0 💤 0 ❌

Results for commit 178cf80.

@edriouk edriouk requested a review from brondani April 2, 2026 15:07
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.73%. Comparing base (2b7a186) to head (026c7f4).

Files with missing lines Patch % Lines
tools/projmgr/src/ProjMgrRpcServer.cpp 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2423   +/-   ##
=======================================
  Coverage   64.73%   64.73%           
=======================================
  Files         145      145           
  Lines       26142    26145    +3     
  Branches    15778    15781    +3     
=======================================
+ Hits        16922    16925    +3     
  Misses       7066     7066           
  Partials     2154     2154           
Flag Coverage Δ
projmgr-cov 87.77% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgrRpcServer.cpp 85.27% <85.71%> (+0.08%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants