Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses missing/incorrect pack reference reporting for solution local packs in the ProjMgr RPC layer (linked to issue #154), ensuring that packs resolved from local paths can be associated back to their originating pack requirements.
Changes:
- Update pack-reference collection to avoid offering “upgrade” versions for project/solution-local packs (packs with an explicit path).
- Update
GetPacksInforeference matching to associate references by resolved pack ID or by equivalent local pack path. - Add an RPC test covering the solution local pack scenario for
GetPacksInfo.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/projmgr/src/ProjMgrRpcServer.cpp | Improves how pack references are collected and matched (ID- or path-based) when generating GetPacksInfo. |
| tools/projmgr/test/src/ProjMgrRpcTests.cpp | Adds a new test for GetPacksInfo in a solution local pack scenario. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test Results 3 files 21 suites 17m 49s ⏱️ Results for commit 178cf80. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2423 +/- ##
=======================================
Coverage 64.73% 64.73%
=======================================
Files 145 145
Lines 26142 26145 +3
Branches 15778 15781 +3
=======================================
+ Hits 16922 16925 +3
Misses 7066 7066
Partials 2154 2154
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Fixes:
Open-CMSIS-Pack/vscode-cmsis-solution#154