[projmgr] Add download-url into error reporting for external generator failures#2414
Merged
brondani merged 7 commits intoOpen-CMSIS-Pack:mainfrom Mar 26, 2026
Merged
Conversation
Test Results 6 files 12 suites 10s ⏱️ Results for commit 32f8c33. ♻️ This comment has been updated with latest results. |
brondani
reviewed
Mar 26, 2026
test/packs/ARM/RteTestGenerator/0.1.0/ARM.RteTestGenerator.pdsc
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thank you for the suggestions. I have also updated the PR description based on changes. Please review them again. |
brondani
reviewed
Mar 26, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2414 +/- ##
==========================================
+ Coverage 64.70% 64.72% +0.02%
==========================================
Files 145 145
Lines 26127 26137 +10
Branches 15767 15774 +7
==========================================
+ Hits 16905 16918 +13
+ Misses 7068 7066 -2
+ Partials 2154 2153 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Open-CMSIS-Pack/vscode-cmsis-solution#104
ProjMgrWorker::ExecuteExtGeneratorto log the generator's download URL on failure, or report its absence if not available.RteChkTestlib test because of the changes inProjMgrExtGenerator.handRteTestGenerator.pdscAfter changes:
download-urlis found in generator.yml and generator returns error--verbose