Skip to content

build/AddOns, appimage fix, version backport, manifest output#553

Merged
AnotherCommander merged 2 commits intoOoliteProject:1.92-maintenancefrom
mcarans:1.92-maintenance
Feb 28, 2026
Merged

build/AddOns, appimage fix, version backport, manifest output#553
AnotherCommander merged 2 commits intoOoliteProject:1.92-maintenancefrom
mcarans:1.92-maintenance

Conversation

@mcarans
Copy link
Contributor

@mcarans mcarans commented Feb 27, 2026

Add AddOns to debug builds of AppImage
Make Addons in build/AddOns instead of project root
Updated NSIS to look in build/AddOns too
Version fixes backported from prod
Output manifest if packageinfo passed (Linux only)

I extracted a Windows test exe to confirm the AddOns folder is still there with the moving of the AddOns folder from project root to root/build.

Make Addons in build/AddOns instead of project root
Updated NSIS to look in build/AddOns
Version fixes backported from prod
Output manifest if packageinfo passed in Linux
@mcarans mcarans changed the title build/AddOns, appimage fix, version backport, manifest ouput build/AddOns, appimage fix, version backport, manifest output Feb 27, 2026
@mcarans
Copy link
Contributor Author

mcarans commented Feb 27, 2026

I've now tested snapshot build on Windows with debug console just to make sure

@AnotherCommander
Copy link
Member

Just some issues with Oolite.nsi - one of the changes seems to be somewhat problematic and I am suspecting a file character encoding issue. Please have a look at that one. The rest appears to be fine. I tested all three build types and all worked as expected on Windows.

Also noting here that this PR is actually implementing a new feature and not a bug fix. Normally the maintenance branch receives only bugfixes to bugs discovered along the way post-release. However, I believe that due to the nature of this particular feature and the fact that other applications like OoliteStarter will depend on it if we are to go for a 1.92.1 release at some point, an exception can be made for this particular one and we can accept it in the 1.92 maintenance branch.

Revert file, then add back build/ on line 136:
File /r "..\..\build\AddOns"
@mcarans
Copy link
Contributor Author

mcarans commented Feb 28, 2026

@dsalt @AnotherCommander I have fixed the issue with OOlite.nsi and tested a snapshot build on Windows with debug console successfully. Please confirm all is good to merge or go ahead and merge.

@AnotherCommander AnotherCommander merged commit e142711 into OoliteProject:1.92-maintenance Feb 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants