Skip to content

[ADD] Player Naming #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YetAnotherMechanicusEnjoyer merged 2 commits into from
Apr 6, 2026
Merged

[ADD] Player Naming #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29416cf
[ADD] Player Name in Core
YetAnotherMechanicusEnjoyer Apr 6, 2026
0f36e42
[FIX] default player name value in definition
YetAnotherMechanicusEnjoyer Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/Core.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class Core {
std::vector<Cell> stringToCells(const std::string& str, float startX, float startY);

public:
explicit Core(const std::string &initalGraphicLib);
explicit Core(const std::string &initalGraphicLib, const std::string& playerName = "Player 1");
~Core();
void run();
};
Expand Down
2 changes: 1 addition & 1 deletion src/Core.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#include "DirectoryScanner.hpp"

namespace Arcade {
Core::Core(const std::string& initialGraphicLib) : _state(State::Menu), _currentGraphIdx(0), _currentGameIdx(0), _menuSelectionIdx(0), _isRunning(true) {
Core::Core(const std::string& initialGraphicLib, const std::string& playerName) : _state(State::Menu), _currentGraphIdx(0), _currentGameIdx(0), _menuSelectionIdx(0), _playerName(playerName), _isRunning(true) {
DirectoryScanner::scan("./lib/", _gameLibs, _graphicalLibs);

auto it = std::find(_graphicalLibs.begin(), _graphicalLibs.end(), initialGraphicLib);
Expand Down
Loading